fix: make image processing work in github copilot provider by alexhancock · Pull Request #5687 · block/goose

alexhancock · 2025-11-11T20:58:32Z

Fixes #5497 by sending the Copilot-Vision-Request header with a value of true when there is a processed image in the message

Working example after the change:

Copilot

Pull Request Overview

This PR fixes image processing in the GitHub Copilot provider by adding the Copilot-Vision-Request header when images are detected in the request payload.

Introduces payload_contains_image() helper function to detect images in message content
Modifies get_github_headers() to accept optional payload and conditionally add the vision header
Updates all call sites to pass None when payload inspection is not needed

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/goose/src/providers/githubcopilot.rs	Added image detection logic and updated header generation to include `Copilot-Vision-Request` header when images are present in the payload
ui/desktop/openapi.json	Added newline at end of file for proper formatting

DOsinga · 2025-11-11T21:40:09Z

crates/goose/src/providers/githubcopilot.rs

+    fn payload_contains_image(payload: &Value) -> bool {
+        if let Some(messages) = payload.get("messages").and_then(|m| m.as_array()) {
+            for msg in messages {
+                if let Some(content) = msg.get("content") {


you could do this more functional, like messages.iter.any and then cast the is_object to a single list but up to you

DOsinga · 2025-11-11T21:40:13Z

crates/goose/src/providers/githubcopilot.rs

        let url = url::Url::parse(&format!("{}/chat/completions", endpoint))
            .map_err(|e| ProviderError::RequestFailed(format!("Invalid base URL: {e}")))?;
+
+        // Build headers and include Copilot-Vision-Request when payload contains processed images


I'd drop this comment, but do what it says :)

adding payload to get_github_headers seems a tad awkward. if you just break up that builder below you just go:

let mut request = self.client.post(..).headers() if has_images: request = request.header(that_header) response = request.header(..).send.await?

or some such

then you can leave the other bits alone

* origin/main: (29 commits) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676) fix : action icons overlap session title in chat history (#5684) Document recent goose PRs (#5683) docs: add GOOSE_PATH_ROOT environment variable documentation (#5678) feat: SessionManager integration for acp sessions (#5657) teach copilot our CI (#5672) bump openapi version directly (#5674) governance: update MAINTAINERS.md to reflect new maintainers (#5675) chore: upgrade rmcp to 0.8.5 (#5673) Update release instructions (#5662) Swapped out to_string_lossy with display for user facing text (#5666) ...

* 'main' of github.com:block/goose: Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676)

* main: (27 commits) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676) fix : action icons overlap session title in chat history (#5684) Document recent goose PRs (#5683) docs: add GOOSE_PATH_ROOT environment variable documentation (#5678) feat: SessionManager integration for acp sessions (#5657) teach copilot our CI (#5672) ...

…eanup * 'main' of github.com:block/goose: (46 commits) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676) fix : action icons overlap session title in chat history (#5684) Document recent goose PRs (#5683) ...

* origin/main: (51 commits) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) ...

Signed-off-by: Blair Allan <Blairallan@icloud.com>

alexhancock requested review from DOsinga, Copilot and michaelneale November 11, 2025 20:58

alexhancock mentioned this pull request Nov 11, 2025

Image processing fails when using GitHub CoPilot as LLM provider #5497

Closed

Copilot started reviewing on behalf of alexhancock November 11, 2025 20:59 View session

Copilot finished reviewing on behalf of alexhancock November 11, 2025 21:01

Copilot AI reviewed Nov 11, 2025

View reviewed changes

DOsinga approved these changes Nov 11, 2025

View reviewed changes

alexhancock added 2 commits November 12, 2025 09:50

fix: make image processing work in github copilot provider

2d1fe34

address PR feedback

290e845

alexhancock force-pushed the alexhancock/copilot-openai-image-processing branch from 863febf to 290e845 Compare November 12, 2025 15:10

alexhancock merged commit cd33b23 into main Nov 12, 2025
15 checks passed

Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Nov 17, 2025

fix: make image processing work in github copilot provider (block#5687)

9386a42

arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025

fix: make image processing work in github copilot provider (block#5687)

49ee4f1

github-actions bot mentioned this pull request Nov 18, 2025

chore(release): release version 1.15.0 (minor) #5780

Merged

BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025

fix: make image processing work in github copilot provider (block#5687)

be597a4

Signed-off-by: Blair Allan <Blairallan@icloud.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make image processing work in github copilot provider#5687

fix: make image processing work in github copilot provider#5687
alexhancock merged 2 commits intomainfrom
alexhancock/copilot-openai-image-processing

alexhancock commented Nov 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

DOsinga Nov 11, 2025

Uh oh!

DOsinga Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alexhancock commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

DOsinga Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexhancock commented Nov 11, 2025 •

edited

Loading